Skip to content

Fix background matchmaking crash#751

Merged
asimon-1 merged 1 commit intojugeeya:mainfrom
asimon-1:background-matchmaking-fix
Nov 4, 2025
Merged

Fix background matchmaking crash#751
asimon-1 merged 1 commit intojugeeya:mainfrom
asimon-1:background-matchmaking-fix

Conversation

@asimon-1
Copy link
Collaborator

@asimon-1 asimon-1 commented Nov 3, 2025

When background matchmaking completes, it unloads the player fighter. We weren't handling that gracefully in get_player_dmg_digits, now we just return 0's.

@asimon-1 asimon-1 requested a review from jugeeya as a code owner November 3, 2025 04:34
Copy link
Owner

@jugeeya jugeeya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asimon-1 asimon-1 merged commit 235560e into jugeeya:main Nov 4, 2025
5 checks passed
@asimon-1 asimon-1 deleted the background-matchmaking-fix branch November 4, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants